Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More kyber code refactoring #135

Merged
merged 24 commits into from
Nov 25, 2023
Merged

More kyber code refactoring #135

merged 24 commits into from
Nov 25, 2023

Commits on Nov 20, 2023

  1. Break out matrix multiplication code in ntt.rs.

    @xvzcf
    xvzcf committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    df46ee4 View commit details
    Browse the repository at this point in the history

  2. KyberPolynomialRingElement -> PolynomialRingElement.

    @xvzcf
    xvzcf committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    da0f6cc View commit details
    Browse the repository at this point in the history

  3. KyberFieldElement -> FieldElement.

    @xvzcf
    xvzcf committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0e4d182 View commit details
    Browse the repository at this point in the history

  4. Added some types related to montgomery reduction

    @xvzcf
    xvzcf committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    81369f8 View commit details
    Browse the repository at this point in the history

  5. FieldElement -> StandardFieldElement.

    @xvzcf
    xvzcf committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0f79ee7 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. More annotating with type aliases.

    @xvzcf
    xvzcf committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    c9bd0db View commit details
    Browse the repository at this point in the history

  2. cbd -> sample_vector_cbd_then_ntt.

    @xvzcf
    xvzcf committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    710f698 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Make message compression and decompression constant time.

    @xvzcf
    xvzcf committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    1da97ad View commit details
    Browse the repository at this point in the history

  2. Refine preconditions in compress.

    @xvzcf
    xvzcf committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    24be1ba View commit details
    Browse the repository at this point in the history

  3. Convert (invert_)ntt_at_layer macros to functions.

    @xvzcf
    xvzcf committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2c3b985 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Review comments.

    @xvzcf
    xvzcf committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9731506 View commit details
    Browse the repository at this point in the history

  2. Revert "Convert (invert_)ntt_at_layer macros to functions." 

    This reverts commit 2c3b985.
    @xvzcf
    xvzcf committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    96787ce View commit details
    Browse the repository at this point in the history

  3. Re-extract Kyber fstar code with latest karthik/core-for-kyber hax co… 

    …mmit.
    @xvzcf
    xvzcf committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    7579051 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Fix fstar lax-typechecking.

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    19044b8 View commit details
    Browse the repository at this point in the history

  2. Add comments to ntt.rs.

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    0637fca View commit details
    Browse the repository at this point in the history

  3. Add lax typechecking to CI.

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    aaba346 View commit details
    Browse the repository at this point in the history

  4. 3329 -> FIELD_MODULUS in ntt.rs and update paths in hax.yml

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    c23ba2e View commit details
    Browse the repository at this point in the history

  5. Add cfg guard in ntt.rs

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    ce756a6 View commit details
    Browse the repository at this point in the history

  6. Fixed silly mistake in hax.yml

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    180e67c View commit details
    Browse the repository at this point in the history

  7. Get Fstar binaries in hax.yml.

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    063f95f View commit details
    Browse the repository at this point in the history

  8. Remove spurious slash in hax.yml

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    f50ef7e View commit details
    Browse the repository at this point in the history

  9. Debug hax ci

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    48c942d View commit details
    Browse the repository at this point in the history

  10. Debug hax ci

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    7bbb472 View commit details
    Browse the repository at this point in the history

  11. CI should work now?

    @xvzcf
    xvzcf committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    be406dd View commit details
    Browse the repository at this point in the history