Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kyber512 and Kyber1024 reference implementation #109

Merged
merged 19 commits into from
Oct 11, 2023
Merged

Add Kyber512 and Kyber1024 reference implementation #109

merged 19 commits into from
Oct 11, 2023

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Oct 10, 2023

No description provided.

franziskuskiefer
franziskuskiefer requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment •
edited by xvzcf
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Only a couple nits.

Also

  • Please run the extraction again with hax from main. Some significant changes were merged yesterday.
  • Please do a follow up with a description of how to generate the kats and the code for it.

src/kem/kyber/ind_cpa.rs Show resolved Hide resolved
src/kem/kyber/ind_cpa.rs Outdated Show resolved Hide resolved
src/kem/kyber/sampling.rs Outdated Show resolved Hide resolved
src/kem/kyber/serialize.rs Show resolved Hide resolved
tests/kyber.rs Show resolved Hide resolved
tests/kyber_nistkats.rs Outdated Show resolved Hide resolved
tests/kyber_nistkats.rs Outdated Show resolved Hide resolved
franziskuskiefer
franziskuskiefer approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xvzcf xvzcf merged commit 6a133b9 into dev Oct 11, 2023
9 checks passed
@xvzcf xvzcf deleted the add-kyber512-1024-ref branch October 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees

@xvzcf xvzcf

Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvzcf @franziskuskiefer