Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fstar kyber usize workaround #108

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fstar kyber usize workaround #108

merged 2 commits into from
Oct 10, 2023

Conversation

franziskuskiefer
Copy link
Member

Because of hacspec/hax#274 usize can't be used to match in hax right now. This PR works around this issue for now.

karthikbhargavan
karthikbhargavan approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

In the future, this particular cast will be added automatically in the F* backend by hax and we can remove it from the Rust code.

@franziskuskiefer franziskuskiefer enabled auto-merge (squash) October 10, 2023 09:04
@franziskuskiefer franziskuskiefer merged commit 08bcf36 into dev Oct 10, 2023
9 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/fstar-kyber-usize-workaround branch October 10, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan karthikbhargavan approved these changes

@xvzcf xvzcf Awaiting requested review from xvzcf

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franziskuskiefer @karthikbhargavan