Alerts optionally dismiss after specified duration #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmcgaw
commented
Feb 26, 2023
| @@ -195,7 +195,7 @@ class ChatHandler { | |||
| this.ws.onmessage = this.onWsMessage; | |||
| this.ws.onopen = (event) => { | |||
| event.target.send(this.authToken); | |||
| observer.next(); | |||
| observer.next(isNewRoom); | |||
There was a problem hiding this comment.
If we emit this here, then isNewRoom is exposed to the place in the epic where we show "New room created". (Unintentionally borked previously.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional parameter to the show alert pipeline that makes alerts (optionally) auto-dismissing after a specified duration.
Intended to at least partially address #200
Oh and apparently #139