Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include status 401 as retryable on httpBeaconChannel #434

Closed
wants to merge 1 commit into from

Conversation

georgekaran
Copy link
Member

Summary

This pull request includes changes to the HttpBeaconChannel class and its corresponding test suite. The main objective is to update the retry logic to include handling for unauthorized requests (HTTP status code 401).

Updates to retry logic:

Updates to test suite:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@georgekaran georgekaran added the enhancement New feature or request label Oct 17, 2024
@georgekaran georgekaran self-assigned this Oct 17, 2024
Copy link

pkg-pr-new bot commented Oct 17, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@croct/sdk@434

commit: 7081e79

Copy link

codeclimate bot commented Oct 17, 2024

Code Climate has analyzed commit 7081e79 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.9% (0.0% change).

View more on Code Climate.

@marcospassos
Copy link
Member

Fixed by #436

@marcospassos marcospassos deleted the feat/status-401-retryable branch October 17, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants