New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base 64 decoding #80

Merged

marcospassos merged 1 commit into master from fix-base64-parsing

Oct 15, 2024

Member

renan628 commented Oct 15, 2024

Summary

This PR fixes the base64 decoding to handle UTF-8 emojis, which prevents the plug from invalidating valid preview tokens.

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings


          fix base 64 parsing

902f636

renan628 added the bug label

pkg-pr-new bot commented Oct 15, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@croct/plug-next@80

commit: 902f636

renan628 requested a review from marcospassos

October 15, 2024 22:21

marcospassos approved these changes

View reviewed changes

marcospassos merged commit c45f586 into master

8 checks passed

marcospassos deleted the fix-base64-parsing branch

October 15, 2024 23:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug