replica-read request with mixed strategy and with label, should be ab…

…le to retry all remain replicas

Signed-off-by: crazycs520 <[email protected]>

internal/locate/region_request.go

@@ -774,7 +774,7 @@ func (state *accessFollower) next(bo *retry.Backoffer, selector *replicaSelector
  // If the leader is also unavailable, we can fallback to the follower and use replica-read flag again,
  // The remote follower not tried yet, and the local follower can retry without stale-read flag.
  // If leader tried and received deadline exceeded error, try follower.
- if state.isStaleRead || leader.deadlineErrUsingConfTimeout {
+ if state.isStaleRead || leader.deadlineErrUsingConfTimeout || len(state.option.labels) > 0 {
  selector.state = &tryFollower{
  leaderIdx: state.leaderIdx,
  lastIdx: state.leaderIdx,

internal/locate/replica_selector_test.go

@@ -271,6 +271,50 @@ func TestReplicaReadAccessPathByCase(t *testing.T) {
  }
  s.True(s.runCaseAndCompare(ca))
  s.changeRegionLeader(1)
+
+ ca = replicaSelectorAccessPathCase{
+ reqType: tikvrpc.CmdGet,
+ readType: kv.ReplicaReadMixed,
+ staleRead: false,
+ timeout: time.Second,
+ label: &metapb.StoreLabel{Key: "id", Value: "2"},
+ accessErr: []RegionErrorType{DeadLineExceededErr, ServerIsBusyErr},
+ expect: &accessPathResult{
+ accessPath: []string{
+ "{addr: store2, replica-read: true, stale-read: false}",
+ "{addr: store1, replica-read: true, stale-read: false}",
+ "{addr: store3, replica-read: true, stale-read: false}"},
+ respErr: "",
+ respRegionError: nil,
+ backoffCnt: 0,
+ backoffDetail: []string{},
+ regionIsValid: true,
+ },
+ }
+ s.True(s.runCaseAndCompare(ca))
+
+ s.changeRegionLeader(2)
+ ca = replicaSelectorAccessPathCase{
+ reqType: tikvrpc.CmdGet,
+ readType: kv.ReplicaReadMixed,
+ staleRead: false,
+ timeout: time.Second,
+ label: &metapb.StoreLabel{Key: "id", Value: "3"},
+ accessErr: []RegionErrorType{DeadLineExceededErr, ServerIsBusyErr},
+ expect: &accessPathResult{
+ accessPath: []string{
+ "{addr: store3, replica-read: true, stale-read: false}",
+ "{addr: store2, replica-read: true, stale-read: false}",
+ "{addr: store1, replica-read: true, stale-read: false}"},
+ respErr: "",
+ respRegionError: nil,
+ backoffCnt: 0,
+ backoffDetail: []string{},
+ regionIsValid: true,
+ },
+ }
+ s.True(s.runCaseAndCompare(ca))
+ s.changeRegionLeader(1)
 }
 
 func (s *testReplicaSelectorSuite) changeRegionLeader(storeId uint64) {