Refactoring: Modularize CrateCompiler
#498
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| _column_as_key, | ||
| _getattr_col_key, | ||
| _col_bind_name, | ||
| ) = _key_getters_for_crud_column(compiler, stmt) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
There was a problem hiding this comment.
CodeQL is comparing apples with oranges here and below. I think it does not get SQLAlchemy's versions right, and compares the wrong versions.
There was a problem hiding this comment.
Let's see if it will get fixed by GH-499.
There was a problem hiding this comment.
I think CodeQL will not be smart enough to handle this case, when a code base contains code which calls functions or methods in 3rd-party libraries with different signatures, because of their evolutions across different versions.
So, I think we will have to go with manually dismissing those Wrong number of arguments in a call admonitions. Please correct me if I am wrong.
| _scan_insert_from_select_cols( | ||
| compiler, | ||
| stmt, | ||
| parameters, | ||
| _getattr_col_key, | ||
| _column_as_key, | ||
| _col_bind_name, | ||
| check_columns, | ||
| values, | ||
| kw, | ||
| ) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
| _scan_cols( | ||
| compiler, | ||
| stmt, | ||
| parameters, | ||
| _getattr_col_key, | ||
| _column_as_key, | ||
| _col_bind_name, | ||
| check_columns, | ||
| values, | ||
| kw, | ||
| ) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
| """ | ||
|
|
||
| if stmt._has_multi_parameters: | ||
| values = _extend_values_for_multiparams(compiler, stmt, values, kw) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
amotl
force-pushed
the
amo/refactor-core-patches
branch
from
48640bb
to
248d60e
Compare
By refactoring the SQLAlchemy 1.0-1.3 vs. 1.4 specialities of the `CrateCompiler` (`visit_update` and `_get_crud_params`) into dedicated modules, the new layout is more suitable for bringing in support for SQLAlchemy 2.0.
amotl
force-pushed
the
amo/refactor-core-patches
branch
from
248d60e
to
e969ae3
Compare
|
|
||
| if self.ctes: | ||
| nesting_level = len(self.stack) if not toplevel else None | ||
| text = self._render_cte_clause(nesting_level=nesting_level) + text |
Check failure
Code scanning / CodeQL
Wrong name for an argument in a call
| _column_as_key, | ||
| _getattr_col_key, | ||
| _col_bind_name, | ||
| ) = getters = _key_getters_for_crud_column(compiler, stmt, compile_state) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
| _scan_insert_from_select_cols( | ||
| compiler, | ||
| stmt, | ||
| compile_state, | ||
| parameters, | ||
| _getattr_col_key, | ||
| _column_as_key, | ||
| _col_bind_name, | ||
| check_columns, | ||
| values, | ||
| kw, | ||
| ) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
| _scan_cols( | ||
| compiler, | ||
| stmt, | ||
| compile_state, | ||
| parameters, | ||
| _getattr_col_key, | ||
| _column_as_key, | ||
| _col_bind_name, | ||
| check_columns, | ||
| values, | ||
| kw, | ||
| ) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
| values = _extend_values_for_multiparams( | ||
| compiler, | ||
| stmt, | ||
| compile_state, | ||
| values, | ||
| _column_as_key, | ||
| kw, | ||
| ) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
About
By refactoring the SQLAlchemy 1.0-1.3 vs. 1.4 specialities of the
CrateCompiler(visit_updateand_get_crud_params) into dedicated modules, the new layout is more suitable for bringing in support for SQLAlchemy 2.0.Details
Effectively, it moves code from
crate.client.sqlalchemy.compilerintocrate.client.sqlalchemy.compat.core{10,14}.References