Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library.json specifies libCompatMode strict #2111

Merged
merged 1 commit into from
Jun 26, 2024
Merged

library.json specifies libCompatMode strict #2111

merged 1 commit into from
Jun 26, 2024

Conversation

rob-deutsch
Copy link
Contributor

This PR is based on platformio's documentation. I will test it next week.

This PR instructs platformio to pay attention to both the frameworks AND platforms specification before trying to compile IRremoteESP8266.

I would've thought that platformio would do this check by default, but apparently not. By default it only checks frameworks. Source: https://docs.platformio.org/en/latest/manifests/library-json/fields/platforms.html

The documentation for libCompatMode can be found here: https://docs.platformio.org/en/latest/manifests/library-json/fields/build/libcompatmode.html#manifest-library-json-build-libcompatmode

Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crankyoldgit
Copy link
Owner

BTW, thanks for this.

@crankyoldgit crankyoldgit merged commit dc0fd31 into crankyoldgit:master Jun 26, 2024
42 checks passed
@rob-deutsch rob-deutsch deleted the patch-1 branch June 26, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants