Skip to content

Commit

Permalink
#390 fix qulice
Browse files Browse the repository at this point in the history
  • Loading branch information
HDouss committed Feb 24, 2020
1 parent de94b2d commit 6691094
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/main/java/org/jpeek/XslReport.java
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,12 @@ final class XslReport implements Report {
* @param calc Calculus
* @param mean Mean
* @param sigma Sigma
* @todo #390:30min this constructor now has too many arguments. We should find a way to refactor the constructor
* or the class to have fewer parameters. We could start by analyzing the usage of this.params (args in this
* constructor) and get rid of it if it is not used. Another idea could be to have a data class contaning
* reporting params: name, args, mean, sigma.
* @todo #390:30min this constructor now has too many arguments. We should find a way
* to refactor the constructor or the class to have fewer parameters.
* We could start by analyzing the usage of this.params (args in this
* constructor) and get rid of it if it is not used.
* Another idea could be to have a data class contaning reporting params:
* name, args, mean, sigma.
* @checkstyle ParameterNumberCheck (10 lines)
*/
XslReport(final XML xml, final String name,
Expand Down

0 comments on commit 6691094

Please sign in to comment.