Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4: Initialize the import level at 0 instead of -1, for Python 3 compatibility #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#4: Initialize the import level at 0 instead of -1, for Python 3 compatibility #7

wants to merge 1 commit into from

Conversation

nicoulaj
Copy link

(I did not test on Python 2 after this change)

@nicoulaj nicoulaj mentioned this pull request Nov 28, 2017
Open
@nicoulaj
Copy link
Author

@cournape any chance you could review this ?

@RafalSkolasinski
Copy link

Any chance this could be merged?

@pb-cdunn
Copy link

pb-cdunn commented Oct 6, 2020

This works great for me! I pip install --user import_profiler and then modify one line in-place. I'm glad it's so simple to fix.

@xingren23
Copy link

Any chance this could be merged?

@julien-blanchon
Copy link

Wtf why is this not merged ?

@prashantsengar-cl
Copy link

I forked to add support for Python 3 and it does work well. https://github.com/prashantsengar-cl/import-profiler.

I have made more changes other than the changes in this PR (also contributed #10 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nicoulaj @RafalSkolasinski @pb-cdunn @xingren23 @julien-blanchon @prashantsengar-cl