Remove duplication of ConvertToErrorEvents #7467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
|
damiannolan
reviewed
Oct 15, 2024
| @@ -127,7 +127,7 @@ func (k *Keeper) RecvPacket(ctx context.Context, msg *channeltypesv2.MsgRecvPack | |||
| writeFn() | |||
| } else { | |||
| // Modify events in cached context to reflect unsuccessful acknowledgement | |||
| sdkCtx.EventManager().EmitEvents(convertToErrorEvents(cacheCtx.EventManager().Events())) | |||
| sdkCtx.EventManager().EmitEvents(internalerrors.ConvertToErrorEvents(cacheCtx.EventManager().Events())) | |||
There was a problem hiding this comment.
think this is duplicate import, see ibcerrors
There was a problem hiding this comment.
oh wait, its not duplicate... should we just put it in ibcerrors none the less?
There was a problem hiding this comment.
I guess we can do that yeah, no harm
There was a problem hiding this comment.
oh, ibcerrors is exported, it's not under internal.
chatton
deleted the
cian/issue#7436-remove-duplication-of-converttoerrorevents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7436
This PR moves the error conversion into the internal directory, and includes the code improvement suggested by @bznein
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.