Fix Wasm E2E Tests #6660
Merged
Fix Wasm E2E Tests #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
damiannolan,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
damiannolan
approved these changes
Jun 20, 2024
when running tests locally with older images these tests pass. We'll need to decide how to proceed with this breaking change |
|
oh, this is a contract api breaking change 👀 |
10 tasks
An attempt was made. 733539c |
|
|
Can we merge this so I can run tests on #6644? or is there anything else left to do? |
|
@damiannolan think we can merge when ready, and can look into any failures after your PR gets merged after the fact |
gjermundgaraba
approved these changes
Jun 24, 2024
bznein
pushed a commit
that referenced
this pull request
Jun 26, 2024
* wip: fixing wasm tests * chore: fix wasm tests * chore: removed excess log lines --------- Co-authored-by: Damian Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Marking as R4R to trigger E2Es.
This PR fixes the E2E wasm tests (with the exclusion of the MsgTransfer tests which fail due to ics20-v2)
The Setup logic is moved into SetupSuite and SetupTest, and the
ConfigureRelayerfn is finally removed 🥳I added some additional log lines as debugging the hyperspace relayer was quite difficult due to it hanging rather than erroring.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.