chore: limit packet data to length of one.

cosmos · Oct 21, 2024 · 1b0f052 · 1b0f052
1 parent 6078dda
commit 1b0f052
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/modules/core/04-channel/v2/types/msgs_test.go b/modules/core/04-channel/v2/types/msgs_test.go
@@ -175,6 +175,13 @@ func (s *TypesTestSuite) TestMsgSendPacketValidateBasic() {
  },
  {
  name: "failure: invalid length for payload",
+ malleate: func() {
+ msg.Payloads = []types.Payload{{}, {}}
+ },
+ expError: types.ErrInvalidPayload,
+ },
+ {
+ name: "failure: invalid packetdata",
  malleate: func() {
  msg.Payloads = []types.Payload{}
  },
@@ -241,6 +248,13 @@ func (s *TypesTestSuite) TestMsgRecvPacketValidateBasic() {
  },
  expError: commitmenttypes.ErrInvalidProof,
  },
+ {
+ name: "failure: invalid length for packet payloads",
+ malleate: func() {
+ msg.Packet.Payloads = []types.Payload{{}, {}}
+ },
+ expError: types.ErrInvalidPacket,
+ },
  {
  name: "failure: invalid signer",
  malleate: func() {
@@ -288,6 +302,13 @@ func (s *TypesTestSuite) TestMsgAcknowledge_ValidateBasic() {
  },
  expError: commitmenttypes.ErrInvalidProof,
  },
+ {
+ name: "failure: invalid length for packet payloads",
+ malleate: func() {
+ msg.Packet.Payloads = []types.Payload{{}, {}}
+ },
+ expError: types.ErrInvalidPacket,
+ },
  {
  name: "failure: invalid signer",
  malleate: func() {
@@ -345,6 +366,13 @@ func (s *TypesTestSuite) TestMsgTimeoutValidateBasic() {
  },
  expError: ibcerrors.ErrInvalidAddress,
  },
+ {
+ name: "failure: invalid length for packet payloads",
+ malleate: func() {
+ msg.Packet.Payloads = []types.Payload{{}, {}}
+ },
+ expError: types.ErrInvalidPacket,
+ },
  {
  name: "failure: invalid packet",
  malleate: func() {

diff --git a/modules/core/04-channel/v2/types/packet.go b/modules/core/04-channel/v2/types/packet.go
@@ -32,7 +32,7 @@ func NewPayload(sourcePort, destPort, version, encoding string, value []byte) Pa
 
 // ValidateBasic validates that a Packet satisfies the basic requirements.
 func (p Packet) ValidateBasic() error {
- if len(p.Payloads) == 0 {
+ if len(p.Payloads) != 1 {
  return errorsmod.Wrap(ErrInvalidPacket, "payloads must not be empty")
  }