Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow full control on rocksdb db opening #104

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Mar 15, 2024

this API was previously supported in cometbft-db and used by us to support multiple processes reading from the same db concurrently.

Summary by CodeRabbit

  • New Features
    • Introduced a feature for enhanced control over RocksDB initialization.
  • Refactor
    • Updated random number generation to use secure methods in tests.
    • Improved RocksDB construction process for consistency and flexibility.

@yihuang yihuang requested a review from a team as a code owner March 15, 2024 08:52
Copy link
Contributor

coderabbitai bot commented Mar 15, 2024

Walkthrough

The recent update enhances user control over RocksDB instance initialization, offering extensive customization options. This improvement focuses on the rocksdb.go file, providing users with increased flexibility and customization capabilities for creating RocksDB instances.

Changes

File(s) Change Summary
CHANGELOG.md
rocksdb.go
Added a new feature in the unreleased version to allow full control in RocksDB opening. Modified NewRocksDBWithOptions to return NewRocksDBWithRawDB instead of NewRocksDBWithRaw, introducing NewRocksDBWithRawDB for full control over DB instance construction.
prefixdb_test.go Replaced math/rand with crypto/rand for secure random number generation in prefixdb_test.go.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

CHANGELOG.md Show resolved Hide resolved
@@ -1,5 +1,9 @@
# Changelog

## UNRELEASED

* Allow full control in rocksdb opening
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider rephrasing to enhance clarity and correct the spelling mistake.

- * Allow full control in rocksdb opening
+ * Allow full control over RocksDB opening

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
* Allow full control in rocksdb opening
* Allow full control over RocksDB opening

prefixdb_test.go Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@tac0turtle tac0turtle merged commit e75f6e4 into cosmos:main Apr 8, 2024
4 of 5 checks passed
mmsqe pushed a commit to mmsqe/cosmos-db that referenced this pull request Sep 25, 2024
* feat: allow full control on rocksdb db opening

* Update prefixdb_test.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants