-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navbar redesign #193
Navbar redesign #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great - just gonna merge it
return ( | ||
<Button | ||
type="primary" | ||
className={`login LoginButton-button ${attention ? "LoginButton-attention" : ""}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like attention
isn't fully wired up -- not working in this version
but thats fine, it's probably time for a better solution LOL
Changes
Typescript support (#63)
@babel/preset-typescript
client/src/typedefs
folder contains ambient declarations for missing typedefsImplement Navbar Redesign
<Router>
(Refactor Navbar structure to avoid double router #65)LayoutContext
is defined for js to discriminate viewport type. Cutoff values are 1280px and 720px width currentlyRefactored
ContentManager
ContentManager
is now a singleton classLanguageContext
is defined to allow components to get the current language