Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar redesign #193

Merged
merged 12 commits into from
Feb 20, 2024
Merged

Navbar redesign #193

merged 12 commits into from
Feb 20, 2024

Conversation

vunyunt
Copy link
Collaborator

@vunyunt vunyunt commented Dec 27, 2023

Changes

Typescript support (#63)

  • Frontend typescript support added with @babel/preset-typescript
  • client/src/typedefs folder contains ambient declarations for missing typedefs

Implement Navbar Redesign

  • In some viewport width there isn't enough space to show the whole title, especially in tourney routes. Below are responsive layouts in different width:
    Screenshot_20231227_125201
    Screenshot_20231227_125319
    Screenshot_20231227_125358
    Screenshot_20231227_125424
    Screenshot_20231227_125442
  • Navbar no longer uses a second <Router> (Refactor Navbar structure to avoid double router #65)
  • A LayoutContext is defined for js to discriminate viewport type. Cutoff values are 1280px and 720px width currently
  • In a narrower viewport, the new tourney home banner overflows (unchanged, out of scope for this pr)
  • User settings modal is not changed (out of scope for this pr)

Refactored ContentManager

  • ContentManager is now a singleton class
  • LanguageContext is defined to allow components to get the current language
  • Changing languages no longer reloads the page

cory2067
cory2067 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Owner

@cory2067 cory2067 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - just gonna merge it

client/src/components/modules/Navbar/Right/Regular/LoginButton.tsx
return (
<Button
type="primary"
className={`login LoginButton-button ${attention ? "LoginButton-attention" : ""}`}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like attention isn't fully wired up -- not working in this version
but thats fine, it's probably time for a better solution LOL

@cory2067 cory2067 merged commit ce4305d into cory2067:master Feb 20, 2024
1 check passed
This was referenced Feb 20, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cory2067 cory2067 cory2067 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vunyunt @cory2067