Increased database limits #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinerare
added
bug
itinerare
approved these changes
May 16, 2024
AW0005
approved these changes
May 17, 2024
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussed in #955 - I've altered the columns from a varchar to a text, as those have no limits.
I used a clean lk release environment to see what the correct values were regarding nullable.. Effectively; I did my research. :)
Also tested it on my copy of an existing Lorekeeper: and it does not seem to cause any issues with the database.
Have also tested if it messes anything up on said local by granting myself items and currency: Seems to be working just fine, at least for the items_log, user_items and currencies_log tables.. so I'm fairly convinced this is all done correctly. :)