Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Mentions: Re-Extended #1097

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

SpeedyD
Copy link
Contributor

@SpeedyD SpeedyD commented Oct 28, 2024

Based on the conversation in issue #1083 and the original hashing PR #749, I bring you:
Extended Mentions: Re-Extended

..in draft, because I feel like taking a break right now, but wanted to put it up for potential comments.

PR currently adds:
parseItems
parseTraitThumbs
parseItemThumbs
parsePrompts
parsePromptThumbs
(+ idUrl attribute to Prompts Model)

Still on the planning:
parseRarityThumbs
parseSpeciesThumbs
parseSubtypeThumbs
parseShopTumbs
parseCurrencyThumbs
parseCharacterCategoryThumbs
parsePromptCategoryThumbs
parseTraitCategoryThumbs
parseItemCategoryThumbs

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Oct 28, 2024

And yes, I do in fact plan to also add little text blocks for administration to explain usage, as I did for Character and User mentions prior.

@itinerare itinerare added the enhancement New feature or request label Oct 28, 2024
@itinerare
Copy link
Collaborator

I feel vaguely that at least some of the more niche ones (categories etc) should be behind toggles... at which point they probably all should be,

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Oct 28, 2024

Can do! I'll even do it for the older mentions.

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Oct 30, 2024

Thanks Merc, can always count on you for this. Will fix this all in a bit. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants