Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cache watchers behavior #681

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix: Cache watchers behavior #681

merged 2 commits into from
Oct 16, 2024

Conversation

JeangelLF
Copy link
Contributor

@JeangelLF JeangelLF commented Oct 15, 2024 •
edited
Loading

Ticket

https://github.com/corona-school/project-user/issues/1353

What was done?

  • Move watchers to a separate map to avoid losing them when the cache entry is removed. With this, features like refetchQueries on useMutations work again (Which fixes the reported issue)

@Jonasdoubleyou Jonasdoubleyou temporarily deployed to user-app-fix-cache-watc-0m3y1o October 15, 2024 14:11 Inactive
Jonasdoubleyou
Jonasdoubleyou previously approved these changes Oct 15, 2024
View reviewed changes
src/hooks/useApollo.tsx Show resolved Hide resolved
@JeangelLF JeangelLF marked this pull request as ready for review October 16, 2024 07:30
@Jonasdoubleyou Jonasdoubleyou temporarily deployed to user-app-fix-cache-watc-0m3y1o October 16, 2024 07:31 Inactive
@JeangelLF JeangelLF merged commit de2e2b0 into main Oct 16, 2024
3 checks passed
@JeangelLF JeangelLF deleted the fix/cache-watchers branch October 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonasdoubleyou Jonasdoubleyou Jonasdoubleyou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeangelLF @Jonasdoubleyou