Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Overflowing modals #671

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fix: Overflowing modals #671

merged 3 commits into from
Sep 26, 2024

Conversation

JeangelLF
Copy link
Contributor

Ticket

https://github.com/corona-school/project-user/issues/1305

What was done?

  • Removed native-base from InformationModal to re-use it in other places
  • Replaced the remaining overflowing modals with the new InformationModal that doesn't cause overflow with the title and the close button
Bildschirmfoto 2024-09-26 um 10 18 35 Bildschirmfoto 2024-09-26 um 10 18 50

@Jonasdoubleyou Jonasdoubleyou temporarily deployed to user-app-fix-overflowin-n96oxg September 26, 2024 08:19 Inactive
@JeangelLF JeangelLF merged commit 38e9c06 into main Sep 26, 2024
3 checks passed
@JeangelLF JeangelLF deleted the fix/overflowing-modals branch September 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants