Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Achievement Modal / Shine animations with CSS #669

Merged
merged 8 commits into from
Sep 23, 2024
Merged

Feat: Achievement Modal / Shine animations with CSS #669

merged 8 commits into from
Sep 23, 2024

Conversation

JeangelLF
Copy link
Contributor

Ticket

https://github.com/corona-school/project-user/issues/1343

What was done?

  • Rebuild stars animations with CSS for better performance (Now they're not laggy due to intervals and JS stuff)
  • Rebuild AchievementModal with new Modal component
Bildschirmaufnahme.2024-09-20.um.15.36.32.mov

@Jonasdoubleyou Jonasdoubleyou temporarily deployed to user-app-feat-achieveme-5o8xmi September 20, 2024 13:37 Inactive
@Jonasdoubleyou Jonasdoubleyou temporarily deployed to user-app-feat-achieveme-5o8xmi September 20, 2024 13:45 Inactive
@JeangelLF JeangelLF changed the title Feat: Achievement Modal Feat: Achievement Modal with new Components / Shine animations with CSS Sep 20, 2024
@JeangelLF JeangelLF changed the title Feat: Achievement Modal with new Components / Shine animations with CSS Feat: Achievement Modal / Shine animations with CSS Sep 20, 2024
Jonasdoubleyou
Jonasdoubleyou approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@Jonasdoubleyou Jonasdoubleyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - Finally this is done in CSS! (Already discussed this back then, but in the end this was not implemented because it was "too complex" - you make it look simple ;))

@Jonasdoubleyou Jonasdoubleyou temporarily deployed to user-app-feat-achieveme-5o8xmi September 23, 2024 08:43 Inactive
@JeangelLF JeangelLF merged commit 5263119 into main Sep 23, 2024
3 checks passed
@JeangelLF JeangelLF deleted the feat/achievement-modal branch September 23, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonasdoubleyou Jonasdoubleyou Jonasdoubleyou approved these changes

@cr-eative-dev cr-eative-dev cr-eative-dev approved these changes

@MartinEichinger MartinEichinger Awaiting requested review from MartinEichinger

@realmayus realmayus Awaiting requested review from realmayus

@Fabian5150 Fabian5150 Awaiting requested review from Fabian5150

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeangelLF @cr-eative-dev @Jonasdoubleyou