-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Fix: Add Prospects to Subcourse #560
base: main
Are you sure you want to change the base?
Conversation
realmayus
commented
Jun 6, 2024
•
edited
Loading
edited
- Add prospect list in course overview to allow instructors to add prospects (frontend part of Store prospect chats in subcourse entity backend#1093)
- This reuses the waiting list component
- Update browserslist
…pects, prevent user from changing email to itself (violates uniqueness constraint in DB)
(would prefer one change per PR) |
# Conflicts: # src/modals/AddPupilModal.tsx # src/pages/student/SingleCourseStudent.tsx
…8c09c12eb929 on backend
# Conflicts: # src/pages/student/SingleCourseStudent.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This can be tackled in a separate task) I noticed a small, unexpected behavior:
When a pupil clicks on Kursleiter:in kontaktieren
, they are immediately marked as a prospect on the CoursePage, even if they haven't sent a message yet. This feels a bit unexpected (At least for me 😅)
Could we:
- Filter out empty chat prospects: Only show users as prospects once they've sent a message.
- Add a confirmation modal: Inform the user that they’ll be added as a prospect after confirming.
Other than that, it looks good, thank you! 💯
)} | ||
{showWaitingListProspectListTab && ( | ||
<TabsContent value="prospect-list"> | ||
<WaitingListProspectList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also tackle this in a separate task:
It would be nice to include a button to open the chat with a specific prospect.
We just need to add a prop to WaitingListProspectList
onContact?: (pupilId: string) => void
and pass it to the ParticipantRow
(which already renders a chat button).
Then, on the SingleCourseStudent
, we just navigate to that conversation.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea! I'll implement it here.
How could we implement filtering out the empty chats?
I think the latter should be our preferred approach for performance reasons. |
That one makes sense. But now that I think about it twice, even if we filter out empty chats, the flow still would be a bit weird. It would be something like:
This feels a bit off. I think we should just add a modal informing the user about what happens if they proceed to the chat. |
I think this does make sense, as HuH know that prospects are interested users that contacted them via chat. We should change the notfication action though, good idea. Then we can have something like "Max has added you to course X" |