Skip to content

Commit

Permalink
Fix: Feedback Improvements (#653)
Browse files Browse the repository at this point in the history
  • Loading branch information
JeangelLF authored Sep 13, 2024
1 parent 01d7bd6 commit 5839e77
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/assets/icons/loki.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/components/BackButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const BackButton: React.FC<Props> = ({ onPress, previousFallbackRoute: fallback
};
return (
<Button variant="none" size="icon" onClick={handleOnBack}>
<IconArrowLeft size={24} />
<IconArrowLeft size={26} style={{ strokeWidth: '1.5px' }} />
</Button>
);
};
Expand Down
19 changes: 11 additions & 8 deletions src/components/HeaderCard.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { ReactNode } from 'react';
import BackButton from './BackButton';
import { NavLink } from 'react-router-dom';
import Loki from '../assets/icons/loki.svg';

type Props = {
Expand All @@ -23,17 +24,19 @@ const HeaderCard: React.FC<Props> = ({ children, leftContent, rightContent, onBa
<div className="h-14 bg-primary-light fixed py-4 z-50 top-0 left-0 right-0">
<div className="flex items-center justify-between h-full px-4">
<div className="flex items-center">
{showBack && <BackButton onPress={onBack} previousFallbackRoute={previousFallbackRoute} />}
<Loki className="hidden lg:block" />
<div className={showBack ? '' : 'invisible'}>
<BackButton onPress={onBack} previousFallbackRoute={previousFallbackRoute} />
</div>
<NavLink to="/start" className="ml-1">
<Loki className="w-[106px] h-[34px] lg:w-[125px] lg:h-[40px]" />
</NavLink>
</div>
<div className="flex flex-row items-center justify-between w-full lg:hidden">
<div className="flex items-center">
{rightContent}
{!showBack && <Loki className="lg:hidden" />}
<div className="flex flex-row items-center justify-end w-full md:hidden">
<div className="flex flex-row items-center">
{leftContent} {rightContent}
</div>
<div className="flex flex-row items-center">{leftContent}</div>
</div>
<div className="flex-row justify-end hidden lg:flex">
<div className="flex-row justify-end hidden md:flex">
<div>{leftContent}</div>
<div>{rightContent}</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/pupil/single-course/PupilCourseButtons.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ const PupilCourseButtons: React.FC<ActionButtonProps> = ({ subcourse, refresh, i
{t(`lernfair.reason.course.pupil.${subcourse.canJoin.reason as CanJoinReason}`)}
</Alert>
)}
<div className="flex flex-col items-center gap-y-4 md:flex-row md:gap-x-4 md:flex-wrap lg:w-1/2">
<div className="flex flex-col items-stretch lg:items-center gap-y-4 md:flex-row md:gap-x-4 md:flex-wrap lg:w-1/2">
{!subcourse.isParticipant && subcourse.canJoin?.allowed && (
<Button
disabled={loadingSubcourseJoined}
Expand Down
1 change: 1 addition & 0 deletions src/widgets/AppointmentCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ const AppointmentCard: React.FC<Props> = ({
duration={duration}
isInstructor={isOrganizer}
canJoin={isCurrent}
className="w-full h-[47px] rounded-[4px]"
/>
</VStack>
)}
Expand Down

0 comments on commit 5839e77

Please sign in to comment.