feat: notifications for missed chat messages #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LomyW
commented
Jul 26, 2023
| @@ -412,6 +412,31 @@ const _notificationActions = { | |||
| appointment: sampleAppointment, | |||
| }, | |||
| }, | |||
| missed_one_on_one_chat_message: { | |||
There was a problem hiding this comment.
action for missed 1:1 messages
LomyW
commented
Jul 26, 2023
| loginToken: '', | ||
| }, | ||
| }, | ||
| missed_course_chat_message: { |
There was a problem hiding this comment.
action for missed group chat messages
LomyW
commented
Jul 26, 2023
| } | ||
|
|
||
| const notificationAction = chatType === ChatType.ONE_ON_ONE ? 'missed_one_on_one_chat_message' : 'missed_course_chat_message'; | ||
| await Notification.actionTaken(userToNotify, notificationAction, notificationContext); |
There was a problem hiding this comment.
we dont need to iterate over each participant of a group conversation, because TalkJS itselfs triggers notifications for each participant of the group chat.
…r-missed-chat-notification
| } catch (error) { | ||
| if (error instanceof InvalidSignatureError) { | ||
| logger.info('Invalid Signature'); | ||
| res.status(401).send({ error: 'Unauthorized' }); |
Jonasdoubleyou
approved these changes
Jul 28, 2023
|
merging this as potentially conflicting with #702, won't be deployed so just create a followup PR if necessary :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user should get notifications from Lern-Fair if the user missed some chat messages
What was done?
Tests
concreteNotificationis created after a notification is triggered by TalkJS