Feat: Session manager #1133
Merged
Feat: Session manager #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion=true in roles resolver,
# Conflicts: # graphql/authentication.ts # graphql/user/fields.ts
Jonasdoubleyou
previously approved these changes
Oct 10, 2024
Jonasdoubleyou
approved these changes
Oct 12, 2024
realmayus
added a commit
to corona-school/user-app
that referenced
this pull request
Oct 22, 2024
Closes corona-school/project-user#1243. Related backend PR: corona-school/backend#1133 - Added session manager view accessible through settings - Created `deviceId` which is persisted on the device - Added `SessionCard` component - Adjust "user agent" of token usage <img width="1249" alt="Screenshot 2024-10-21 at 11 03 58" src="https://github.com/user-attachments/assets/591b8212-5654-4e2b-945c-5ae3a64b525d">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/corona-school/project-user/issues/1243.
Related frontend PR: corona-school/user-app#641
What was done
Introduce
deviceIds: a persistent unique device identifier which we can use to track user sessions and map them to physical devicesTrack
deviceIdinuserSessions(change here) andsecretsAdds
invalidateSessionsparameter totokenRevokeendpoint which removes all sessions that were created by the same deviceId that was used to create the tokenloginWithPassword)Potential problems
Users can log in with an invalid device ID, as they get to choose them on their own. Therefore, they can evade getting their sessions invalidated by providing a different device ID than what is stored in the secret.
Is this a scenario we care about?