Allow to skip ConfigMap creation #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where zones are different but plugins are. In order to avoid duplication of whole zone block configuration, allow to disable config map creation and let it to be managable externally, where it is possible to keep plugins configuration same, but change zone definition only. Signed-off-by: Dinar Valeev <[email protected]>
|
This change is important as it enables using CoreDNS as an external nameserver for Ingress/Gateway resources. For example the k8gb, which is a Geo redundant load balancer, manage the definition of the Corefile. |
|
Please rebase and bump the chart version |
|
Bump: I woud love to manage the configmap file in a syntax that more closely matches coredns itself, rather than YAML. This is difficult to do in the current helm chart. |
|
Hi, If the PR is safe, can we merge it in #167? I did the requested "rebase and bump", but it only lasts as long as the next version. I cannot edit other people's PRs, so I had to make a new one. |
|
Closing in favor of #167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where zones are different but plugins are. In order to
avoid duplication of whole zone block configuration, allow to disable
config map creation and let it to be managable externally, where it is
possible to keep plugins configuration same, but change zone definition
only.
Signed-off-by: Dinar Valeev [email protected]