Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default value for clusterRole name override #181

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

nikki-quant
Copy link
Contributor

@nikki-quant nikki-quant commented Oct 28, 2024

Why is this pull request needed and what does it do?

This addresses a templating error by adding a default value to the chart.

A thing the maintainers of this repo likely already know but that I felt the need to check while making this PR: setting a Helm value to an empty string results in it being treated as false in if/else statements (https://helm.sh/docs/chart_template_guide/control_structures/#ifelse). So this should be a safe default.

Which issues (if any) are related?

#180

Checklist:

  • I have bumped the chart version according to versioning.
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

@hagaibarel hagaibarel merged commit 1f417ad into coredns:master Oct 28, 2024
2 checks passed
@hagaibarel
Copy link
Collaborator

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants