-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding selectors and names #168
Allow overriding selectors and names #168
Conversation
This would be very helpful for users who are trying to install the helm chart over a "stock" EKS deployment or even a deployment where the managed EKS addon for coredns is being used. @alex-berger could we get this fixed up and ready for review? |
PodDisruptionBudget and ServiceMonitor. This allows adapting to non-standard setups like for example AWS EKS CoreDNS Add-on, which use different labels and selectors. Signed-off-by: Alexander Berger <[email protected]>
This allows adapting to non-standard setups like for example AWS EKS CoreDNS Add-on, which use different names. Signed-off-by: Alexander Berger <[email protected]>
Signed-off-by: Alexander Berger <[email protected]>
0b2e857
to
294222f
Compare
Randomly notifying one of the maintainers for review @mrueg, no urgency or pressure, just would love to make progress on this 😇. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, otherwise LGTM
Signed-off-by: Alexander Berger <[email protected]>
Thanks @alex-berger ! |
Thanks, @alex-berger! |
Why is this pull request needed and what does it do?
This allows adapting to non-standard setups like for example AWS EKS CoreDNS Add-on, which use different labels, selectors and object names. Specifically, it allows
This is achieved by introducing the following optional new settings:
service.selector
{}
deployment.selector
{}
prometheus.service.selector
{}
prometheus.monitor.selector
{}
clusterRole.nameOverride
The changes are fully backward compatible and one has to explicitly opt-in to override the default behavior.
Which issues (if any) are related?
Checklist:
Changes are automatically published when merged to
main
. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.