Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cooja: update config file after save #740

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Cooja: update config file after save #740

wants to merge 1 commit into from

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Nov 2, 2022

If saving fails, the currentConfigFile
should retain its previous value.

Also flip the logic for getting the canonical
file to avoid empty catch blocks.

@pjonsson
Cooja: update config file after save
f0df640 
If saving fails, the currentConfigFile
should retain its previous value.

Also flip the logic for getting the canonical
file to avoid empty catch blocks.
@pjonsson pjonsson marked this pull request as draft November 2, 2022 12:48
@pjonsson
Copy link
Contributor Author

pjonsson commented Nov 2, 2022

This breaks [CONFIG_DIR] and friends in the saved file. Need to untangle currentConfigFile before this can land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pjonsson