Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Mitr’s zstd:chunked integration branch #24287

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 15, 2024

  • Primarily to keep track what exactly is in flight, it’s getting a bit frenetic
  • Also so that I can continue from here tomorrow without having to recreate this.
  • And to run the tests in the standard environment and not my manually-created VM
None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 15, 2024
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@mtrmac mtrmac force-pushed the mitr-zstd-integration branch 5 times, most recently from f0a59b8 to fc147f2 Compare October 16, 2024 23:24
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2024
@mtrmac mtrmac force-pushed the mitr-zstd-integration branch 3 times, most recently from 4c50b92 to 643f12a Compare October 18, 2024 22:17
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
go mod edit -replace github.com/containers/image/v5=github.com/mtrmac/image/v5@untrusted-digest-flag

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac force-pushed the mitr-zstd-integration branch 3 times, most recently from 21926e1 to e639c82 Compare October 22, 2024 21:30
Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac force-pushed the mitr-zstd-integration branch 2 times, most recently from e3d052e to 3764456 Compare October 22, 2024 22:41
@mtrmac mtrmac force-pushed the mitr-zstd-integration branch 5 times, most recently from 9712098 to 9ed1e9a Compare October 22, 2024 23:24
Signed-off-by: Miloslav Trmač <[email protected]>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 4, 2024

Note to self: If/after containers/storage#2156 merges, this PR will need to re-enable enable_partial_images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants