Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/netns: add 60s timeout #2239

Merged
merged 2 commits into from
Nov 8, 2024
Merged

pkg/netns: add 60s timeout #2239

merged 2 commits into from
Nov 8, 2024

Commits on Nov 8, 2024

  1. pkg/netns: simplify UnmountNS() 

    Removing one level of nesting with a early return.

Signed-off-by: Paul Holzinger <[email protected]>
    @Luap99
    Luap99 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    50126e3 View commit details
    Browse the repository at this point in the history

  2. pkg/netns: do not loop forever 

    So this is not so simple as one thinks, apparently there are cases where
it is impossible to remove the file but umount() worked fine...
We fixed one issue that ran into this[1] but there seems to be
another[2] problem, unknown cause yet.

Regardless of the real fix for issue[2] add a timeout to not hang/loop
forever. If we were not able to remove the file after 60s give up and
print an error. Leaking these files is not great as the netns references
stay around but it will not prevent containers from running. It will
only start leaking resources.

[1] https://issues.redhat.com/browse/RHEL-59620
[2] containers/podman#24487

Signed-off-by: Paul Holzinger <[email protected]>
    @Luap99
    Luap99 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ef5388b View commit details
    Browse the repository at this point in the history