config: prefer compose CLI plugin over docker-compose binary #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Fedora has packaged docker-compose v2, /usr/bin/docker-compose is provided by the docker-compose-switch project which is a shim that translates `docker-compose ...` into `docker compose ...` while translating any deprecated CLI arguments into the new compose v2 counterparts. This has been a problem for podman users that have podman-docker installed, because `podman compose` tries to call the docker-compose-switch shim and the shim assumes that `docker compose` will be provided by the actual docker command that calls the appropriate CLI plugin, not a podman wrapper that tries to call the docker-compose shim again, resulting in an endless loop. Changing `podman compose` to prefer calling the docker-compose CLI plugin directly should fix this issue. Ref: https://discussion.fedoraproject.org/t/conflicts-when-trying-to-install-docker-compose-having-podman-and-podman-docker-already-installed/132760/ Ref: https://bugzilla.redhat.com/show_bug.cgi?id=2316333 Signed-off-by: Maxwell G <[email protected]>
Luap99
reviewed
Oct 7, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gotmax23, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! It would to get this released into podman prior to the Fedora 41 Final Freeze on 2024-10-15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Fedora has packaged docker-compose v2, /usr/bin/docker-compose is provided by the docker-compose-switch project which is a shim that translates
docker-compose ...intodocker compose ...while translating any deprecated CLI arguments into the new compose v2 counterparts.This has been a problem for podman users that have podman-docker installed, because
podman composetries to call the docker-compose-switch shim and the shim assumes thatdocker composewill be provided by the actual docker command that calls the appropriate CLI plugin, not a podman wrapper that tries to call the docker-compose shim again, resulting in an endless loop.Changing
podman composeto prefer calling the docker-compose CLI plugin directly should fix this issue.Ref: https://discussion.fedoraproject.org/t/conflicts-when-trying-to-install-docker-compose-having-podman-and-podman-docker-already-installed/132760/
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=2316333
Ref: https://src.fedoraproject.org/rpms/docker-compose/pull-request/11