Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update github.com/containers/storage digest to a397602 #2182

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 1, 2024

This PR contains the following updates:

Package Type Update Change
github.com/containers/storage require digest 8bc8379 -> a397602

Configuration

📅 Schedule: Branch creation - "after 1am and before 11am on the first day of the month" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 1, 2024
Copy link
Contributor Author

renovate bot commented Oct 1, 2024

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 4 additional dependencies were updated

Details:

Package Change
github.com/Microsoft/hcsshim v0.12.6 -> v0.12.7
github.com/klauspost/compress v1.17.9 -> v1.17.10
github.com/vbatts/tar-split v0.11.5 -> v0.11.6
google.golang.org/grpc v1.65.0 -> v1.66.0

@renovate renovate bot force-pushed the renovate/github.com-containers-storage-digest branch from ec89c61 to 2d34cfc Compare October 1, 2024 07:16
@Luap99
Copy link
Member

Luap99 commented Oct 1, 2024

    load_test.go:80: 
        	Error Trace:	/var/tmp/go/src/github.com/containers/common/libimage/load_test.go:80
        	Error:      	Not equal: 
        	            	expected: []string{}
        	            	actual  : []string(nil)
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,3 +1,2 @@
        	            	-([]string) {
        	            	-}
        	            	+([]string) <nil>
        	            	 
        	Test:       	TestLoadByPath
        	Messages:   	testdata/docker-unnamed.tar.xz
--- FAIL: TestLoadByPath (0.70s)

And similar failures, looks like some c/storage change breaks the tests here

@renovate renovate bot force-pushed the renovate/github.com-containers-storage-digest branch from 2d34cfc to 8839020 Compare October 1, 2024 18:23
@Honny1
Copy link
Member

Honny1 commented Oct 2, 2024

I found a commit with a change in c/storage 35b3e0f41bb5 that causes this failure. PR with commit: containers/storage#2087

@renovate renovate bot force-pushed the renovate/github.com-containers-storage-digest branch from 8839020 to 9ad519f Compare October 2, 2024 22:11
@renovate renovate bot changed the title fix(deps): update github.com/containers/storage digest to 4bf3f07 fix(deps): update github.com/containers/storage digest to 0eb3a02 Oct 2, 2024
@Honny1
Copy link
Member

Honny1 commented Oct 3, 2024

I found the cause of the problem. I'm working on a remedy.

@renovate renovate bot force-pushed the renovate/github.com-containers-storage-digest branch 6 times, most recently from 5a9f12d to 7bce87e Compare October 5, 2024 00:22
@renovate renovate bot changed the title fix(deps): update github.com/containers/storage digest to 0eb3a02 fix(deps): update github.com/containers/storage digest to ecfdc25 Oct 5, 2024
@renovate renovate bot changed the title fix(deps): update github.com/containers/storage digest to ecfdc25 fix(deps): update github.com/containers/storage digest to 9dc3881 Oct 7, 2024
@renovate renovate bot force-pushed the renovate/github.com-containers-storage-digest branch 3 times, most recently from 675046d to 921b4ab Compare October 8, 2024 11:16
@renovate renovate bot changed the title fix(deps): update github.com/containers/storage digest to 9dc3881 fix(deps): update github.com/containers/storage digest to a397602 Oct 8, 2024
@renovate renovate bot force-pushed the renovate/github.com-containers-storage-digest branch from 921b4ab to bc65f71 Compare October 8, 2024 19:49
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

@Honny1: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/github.com-containers-storage-digest branch from bc65f71 to 527f3ba Compare October 9, 2024 09:03
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 9, 2024
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b8f8d12 into main Oct 9, 2024
16 checks passed
@renovate renovate bot deleted the renovate/github.com-containers-storage-digest branch October 9, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants