Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] access deleted point in prefetch thread. #343

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

BigVan
Copy link
Member

@BigVan BigVan commented Aug 8, 2024

What this PR does / why we need it:

The DynamicPrefetcher::replay(IFile* imgfile) progress is running in a background thread and it will access an invalid pointer after *imgfile has been deleted in stack_files()

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@BigVan BigVan merged commit 1059cf4 into containerd:main Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant