-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANSIENG-4230] | listener changes (#71) #1802
base: 7.8.x
Are you sure you want to change the base?
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
1 similar comment
|
}{% if kafka_broker_configure_multiple_listeners|bool %}, | ||
'ssl_client_authentication': '{% if ccloud_kafka_enabled|bool %}none{% else %}{{ssl_client_authentication|string|lower}}{% endif %}', | ||
'sasl_protocol': '{% if auth_mode in [\"ldap\", \"ldap_with_oauth\", \"oauth\"] %}OAUTH{% elif ccloud_kafka_enabled|bool %}PLAIN{% else %}{{sasl_protocol}}{% endif %}' | ||
}{% if auth_mode == 'mtls' %}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add config validation to only define auth_mode in case rbac_enabled is true
'sasl_protocol': '{{sasl_protocol}}' | ||
}{% if kafka_broker_configure_control_plane_listener|bool and not kraft_enabled|bool %}, | ||
'controller': { | ||
'name': 'CONTROLLER', | ||
'port': 9089, | ||
'ssl_enabled': {{ssl_enabled|string|lower}}, | ||
'ssl_mutual_auth_enabled': {{ssl_mutual_auth_enabled|string|lower}}, | ||
'ssl_client_authentication': '{{ssl_client_authentication|string|lower}}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test version upgrades to ensure that adding new fields in listeners dict doesnt cause trouble in upgades
Description
Changes in Default listeners
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: