-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANSIENG-4245] | scram support in kraft (#49) #1795
base: 7.8.x
Are you sure you want to change the base?
Conversation
* [ANSIENG-4245] | poc for kraft * [ANSIENG-4245] | bug fix * [ANSIENG-4245] | add new line * [ANSIENG-4245] | run only for admin
🎉 All Contributor License Agreements have been signed. Ready to merge. |
* [ANSIENG-4245] | poc for kraft * [ANSIENG-4245] | bug fix * [ANSIENG-4245] | add new line * [ANSIENG-4245] | run only for admin * [ANSIENG-4245] | add scram 256 * [ANSIENG-4245] | add new line * [ANSIENG-4245] | code fix * [ANSIENG-4245] | added scram test * [ANSIENG-4245] | added scram test and validation * [ANSIENG-4245] | added scram test prepare file * [ANSIENG-4245] | message update * [ANSIENG-4245] | update existing tests * [ANSIENG-4245] | update existing tests * [ANSIENG-4245] | update existing tests * [ANSIENG-4245] | test fix * [ANSIENG-4245] | code fix * [ANSIENG-4245] | code fix * [ANSIENG-4245] | code fix
kafka_controller: | ||
vars: | ||
## Option 2 | ||
kafka_controller_sasl_protocol: plain,scram |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please create 2 separate inventory files for these cases instead of adding 2 options here. I think we can also ignore this one and recommend adding in all
for simplicity
Added some comments, other than those, Please update the molecule scenarios to cover different combinations, the same combination of broker sasl scram and controller sasl plain,scram is added in every scenario. Please add a scenario with kerberos,scram and one with broker also having multiple sasl protocol |
adding to the above, is zk to kraft migration working for the scram scenarios? |
Zk to Kraft migration is working and test for the same has been added. |
…8.x' into scram-kraft-ANSIENG-4245 # Conflicts: # molecule/archive-scram-rhel/molecule.yml
Suggested a couple of minor changes, also please rename the sample inventory files to a more descriptive name, something like inter-broker_scram_kraft.yml and controller-broker_scram_kraft.yaml |
Description
This PR adds a capability for SCRAM authentication with Kraft Controller.
SCRAM authentication 1-pager
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: