[ANSIENG-4245] | scram support in kraft (#49) #1795

mansi-jain-1206 · 2024-09-27T09:00:41Z

Description

This PR adds a capability for SCRAM authentication with Kraft Controller.
SCRAM authentication 1-pager

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
I have added tests that prove my fix is effective or that my feature works
If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

* [ANSIENG-4245] | poc for kraft * [ANSIENG-4245] | bug fix * [ANSIENG-4245] | add new line * [ANSIENG-4245] | run only for admin

confluent-cla-assistant · 2024-09-27T09:00:54Z

🎉 All Contributor License Agreements have been signed. Ready to merge.
_{Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.}

mansisinha · 2024-10-23T07:05:28Z

docs/sample_inventories/scram_kraft.yml

+kafka_controller:
+  vars:
+    ## Option 2
+    kafka_controller_sasl_protocol: plain,scram


please create 2 separate inventory files for these cases instead of adding 2 options here. I think we can also ignore this one and recommend adding in all for simplicity

roles/common/tasks/config_validations.yml

roles/kafka_controller/tasks/get_meta_properties.yml

roles/variables/vars/main.yml

mansisinha · 2024-10-23T07:35:07Z

Added some comments, other than those, Please update the molecule scenarios to cover different combinations, the same combination of broker sasl scram and controller sasl plain,scram is added in every scenario. Please add a scenario with kerberos,scram and one with broker also having multiple sasl protocol

mansisinha · 2024-10-23T07:42:19Z

adding to the above, is zk to kraft migration working for the scram scenarios?

mansi-jain-1206 · 2024-10-24T05:23:45Z

Zk to Kraft migration is working and test for the same has been added.

…8.x' into scram-kraft-ANSIENG-4245 # Conflicts: # molecule/archive-scram-rhel/molecule.yml

molecule/scram-rhel/client_scram.properties

molecule/scram-rhel/verify.yml

docs/sample_inventories/scram_kraft.yml

mansisinha · 2024-10-25T10:22:50Z

Suggested a couple of minor changes, also please rename the sample inventory files to a more descriptive name, something like inter-broker_scram_kraft.yml and controller-broker_scram_kraft.yaml

docs/sample_inventories/migration_sample.yml

mansi-jain-1206 requested a review from a team as a code owner September 27, 2024 09:00

mansi-jain-1206 added 8 commits October 16, 2024 18:34

[ANSIENG-4245] | added more test

f970a44

[ANSIENG-4245] | added more test

599a00f

[ANSIENG-4245] | added sample inventory file

b47eceb

[ANSIENG-4245] | added sample inventory file

0bccff5

[ANSIENG-4245] | add eol

65bb151

[ANSIENG-4245] | modified message

03d870a

[ANSIENG-4245] | modified message

d1b3b84