-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new vars for mtls ansieng 4229 (#53) #1794
base: 7.8.x
Are you sure you want to change the base?
Conversation
* Bump cp-ansible Version: 7.6.2 → 7.6.3 * variables.md updated * Bump CP Version: 7.4.6 → 7.4.7 * Bump cp-ansible Version: 7.4.6 → 7.4.7 * variables.md updated * Bump CP Version: 7.5.5 → 7.5.6 * Bump cp-ansible Version: 7.5.5 → 7.5.6 * variables.md updated * Bump CP Version: 7.3.9 → 7.3.10 * Bump cp-ansible Version: 7.3.10 → 7.3.11 * Bump Version: 7.1.13 → 7.1.14 * variables.md updated * Bump Version: 7.2.11 → 7.2.12 * variables.md updated * Bump Version: 7.0.15 → 7.0.16 * [ANSIENG-4224] | update CHANGELOG.rst (#41) * [ANSIENG-4225] | update CHANGELOG.rst (#42) * [ANSIENG-4226] | update CHANGELOG.rst (#43) * [ANSIENG-4222] | update CHANGELOG.rst (#45) * [ANSIENG-4221] | update CHANGELOG.rst (#46) * [ANSIENG-4220] | update CHANGELOG.rst (#47) * [ANSIENG-4219] | update CHANGELOG.rst (#48) * [ANSIENG-4223] | update CHANGELOG.rst (#44) * [ANSIENG-4223] | update CHANGELOG.rst * [ANSIENG-4223] | update CHANGELOG.rst * [ANSIENG-4229] | adding new user facing variables for rbac over mtls * [ANSIENG-4229] | modifying the default values of ssl_client_authentication and ssl_mutual_auth --------- Co-authored-by: ConfluentSemaphore <[email protected]> Co-authored-by: Mansi Jain <[email protected]>
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
1 similar comment
|
{%- if ssl_mutual_auth_enabled|bool -%} | ||
{%- if deployment_strategy == 'parallel' -%} | ||
required | ||
{%- elif deployment_strategy in ['serial', 'rolling'] -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not defined in case of deployment strategy serial/rolling then we should fail the setup
{%- endif -%} | ||
|
||
# yamllint disable-line rule:key-duplicates | ||
ssl_mutual_auth_enabled: "{{ true if ssl_client_authentication in ['required', 'requested'] else false }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in config validations check if user is defining both these in contrdictory way and stop the setup
Description
Add new variables for RBAC over mTLs
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: