-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI-3095] On kafka topic update --config num.partitions=XXX, poll for updates or print warning #2855
Open
tmalikconfluent
wants to merge
53
commits into
main
Choose a base branch
from
CLI-3095
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,287
−6,618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steven Gagniere <[email protected]>
Co-authored-by: Brian Strauch <[email protected]>
…` commands (#2821)
…idate` (#2829) Co-authored-by: Brian Strauch <[email protected]>
Co-authored-by: Brian Strauch <[email protected]>
…ent kafka quota` commands (#2832) Co-authored-by: Brian Strauch <[email protected]>
Co-authored-by: Steven Gagniere <[email protected]>
Co-authored-by: Brian Strauch <[email protected]>
Co-authored-by: Brian Strauch <[email protected]>
Co-authored-by: Brian Strauch <[email protected]>
brianstrauch
previously approved these changes
Jul 11, 2024
tmalikconfluent
dismissed
brianstrauch’s stale review
August 14, 2024 21:47
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Bug Fixes
confluent kafka topic update my-topic --config num.partitions=X
commandChecklist
What
On
kafka topic update --config num.partitions=XXX
, poll for updates or print warningReferences
https://confluentinc.atlassian.net/browse/CLI-3095
Test & Review
Updated the integration tests.