Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI-3095] On kafka topic update --config num.partitions=XXX, poll for updates or print warning #2855

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

[CLI-3095] On kafka topic update --config num.partitions=XXX, poll for updates or print warning #2855

wants to merge 53 commits into from
+4,287 −6,618

Conversation

tmalikconfluent
Copy link
Contributor

@tmalikconfluent tmalikconfluent commented Jul 10, 2024 •
edited by brianstrauch
Loading

Release Notes

Bug Fixes

  • CLI shows the correct partition count on confluent kafka topic update my-topic --config num.partitions=X command

Checklist

  • Leave this box unchecked if features are not yet available in production

What

On kafka topic update --config num.partitions=XXX, poll for updates or print warning

References

https://confluentinc.atlassian.net/browse/CLI-3095

Test & Review

Updated the integration tests.

GunalKupta and others added 30 commits January 22, 2024 14:30
@GunalKupta @sgagniere
[CLI-2817, DGS-7730] Remove SG cluster CLI commands from v4 (#2531)
c7331de 
Co-authored-by: Steven Gagniere <[email protected]>
@sgagniere
Merge branch 'main' of github.com:confluentinc/cli into v4
a23b980
@sgagniere
[CLI-2705] Switch all delete/undelete confirmation prompts to yes/no (#…
42bd59c 
…2565)
@sgagniere
[CLI-2344, CLI-2437, CLI-2493, CLI-2835, CLI-2847, CLI-2909] Rename v…
73aeb1e 
…arious flags and fields (#2570)
@sgagniere
Merge branch 'main' of github.com:confluentinc/cli into v4
2ce10c4
@sgagniere @brianstrauch
[CLI-2352, CLI-2623, CLI-2695, CLI-2997] Rename some subcommands (#2571)
9a48428 
Co-authored-by: Brian Strauch <[email protected]>
@brianstrauch
Merge branch 'main' into v4
c50734a
@brianstrauch
fix lint
c80d892
@brianstrauch
fix test
735cc85
@brianstrauch
fix linux test
d186962
@brianstrauch
alphabetize
f77cf4e
@GunalKupta
DGS-9904: Update SR Describe CLI v4 to call srcm/v3 API (#2585)
df7b0a9
@sgagniere
merge branch 'main' into v4
2d55303
@sgagniere
fix compile errors
4b0f062
@sgagniere
merge 'main' into v4
6c60856
@sgagniere
fix tests
20b2e0b
@sgagniere
fix test
d71e499
@sgagniere @brianstrauch
[CLI-2303, CLI-2682, CLI-2998, CLI-3007] Remove various flags (#2584)
a0f0dff 
Co-authored-by: Brian Strauch <[email protected]>
@brianstrauch
CLI-3124: Print role bindings with deleted resources (#2749)
d5f91c1
@sgagniere
merge main into v4
fc9026c
@sgagniere
fix tests
c01f407
@sgagniere @brianstrauch
[CLI-2340] Remove .netrc support (#2751)
68e4691 
Co-authored-by: Brian Strauch <[email protected]>
@sgagniere
[CLI-2996] Enable CLI color by default (#2771)
42576ec
@tmalikconfluent
[CLI-2908] Add plugin uninstall command (#2761)
64d79e2
@sgagniere
merge main into v4
2bc26a8
@sgagniere
[CLI-2351] Remove deprecated env vars (#2794)
26b90b5
@brianstrauch
[CLI-2711] Disable updates by default in CP (#2795)
fe34f9e
@sgagniere
merge main into v4
0648e08
@sgagniere
Merge branch 'main' of github.com:confluentinc/cli into v4
a143c33
@sgagniere
redo generate-packaging-patch
195675b
tmalikconfluent and others added 21 commits June 11, 2024 15:10
@tmalikconfluent
[CLI-2697] Replace all instances of "Provider" with "Cloud" (#2809)
d7ffd92
@tmalikconfluent
[CLI-2696] Rename "Schema ID" to "ID" in schema-registry schema list(…
73e8cab 
…#2810)
@sgagniere
[CLI-2339,CLI-2495,CLI-2689,CLI-2318] Rename/remove fields from the c…
d3ac2ba 
…onfiguration file (#2796)
@tmalikconfluent
[CLI-2851] kafka region list output should match flink region list (
b4fee75 
#2812)
@sgagniere
[CLI-2853] Remove environment and context flags from various `use…
e92635c 
…` commands (#2821)
@sgagniere
[CLI-2316] Replace CheckFile with a config field (#2825)
13802b6
@sgagniere @brianstrauch
[CLI-2622] Update flags for `schema-registry schema compatibility val…
d5391e1 
…idate` (#2829)

Co-authored-by: Brian Strauch <[email protected]>
@sgagniere @brianstrauch
[CLI-2584] Remove context create and context update (#2823)
8e3eda1 
Co-authored-by: Brian Strauch <[email protected]>
@tmalikconfluent
"Standardize --ca-location and --ca-cert-path (#2831)
9dde372
@sgagniere @brianstrauch
[CLI-2826] Use array for principals in serialized output of `conflu…
41a1207 
…ent kafka quota` commands (#2832)

Co-authored-by: Brian Strauch <[email protected]>
@sgagniere @brianstrauch
[CLI-2645,CLI-2342,CLI-2391,CLI-3088,CLI-3039] Some flag changes and …
7ca5813 
…add omitempty to some outputs (#2818)

Co-authored-by: Brian Strauch <[email protected]>
@kevin-wu24 @sgagniere
[CLI-2360] Revoking Auth0 refresh token on cloud logout (#2216)
1a432a2 
Co-authored-by: Steven Gagniere <[email protected]>
@tmalikconfluent
[CLI-2566] Make human and serialized field names consistent in link d…
122ce4f 
…escribe/list (#2838)
@sgagniere @brianstrauch
[CLI-2857] Remove flag resolver (#2840)
fdd2708 
Co-authored-by: Brian Strauch <[email protected]>
@sgagniere @brianstrauch
Add prefix for encrypted Windows auth tokens (#2839)
b7abda6 
Co-authored-by: Brian Strauch <[email protected]>
@sgagniere @brianstrauch
[CLI-3117,CLI-2827] use map[string]string for various outputs (#2820)
567513c 
Co-authored-by: Brian Strauch <[email protected]>
@sgagniere
fix lint error
c9bc4cb
@sgagniere
merge main into v4
ac2697d
@sgagniere @brianstrauch
[CLI-2481] Move price and admin commands under billing (#2843)
e62c5c9 
Co-authored-by: Brian Strauch <[email protected]>
@sgagniere
[CLI-2346] Remove legacy cert path support (#2842)
9d04bbc
@tmalikconfluent
On kafka topic update --config num.partitions=XXX, poll for updates o…
b2df1cf 
…r print warning
@tmalikconfluent tmalikconfluent requested a review from a team as a code owner July 10, 2024 21:48
brianstrauch
brianstrauch reviewed Jul 11, 2024
View reviewed changes
internal/kafka/command_topic_update.go Outdated Show resolved Hide resolved
internal/kafka/command_topic_update.go Outdated Show resolved Hide resolved
internal/kafka/command_topic_update.go Outdated Show resolved Hide resolved
internal/kafka/command_topic_update.go Outdated Show resolved Hide resolved
internal/kafka/command_topic_update.go Outdated Show resolved Hide resolved
test/test-server/kafka_rest_router.go Outdated Show resolved Hide resolved
brianstrauch
brianstrauch previously approved these changes Jul 11, 2024
View reviewed changes
Base automatically changed from v4 to main August 12, 2024 20:53
@tmalikconfluent tmalikconfluent dismissed brianstrauch’s stale review August 14, 2024 21:47

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianstrauch brianstrauch brianstrauch left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmalikconfluent @brianstrauch @GunalKupta @sgagniere @kevin-wu24