Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bun v1.1.31 #27937

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding bun v1.1.31 #27937

wants to merge 3 commits into from

Conversation

EmmanuelOga
Copy link

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR () and found it was in an excellent condition.

@EmmanuelOga
Copy link
Author

Points I'm not sure about:

  • There are many licenses for linked libraries, not sure if I need to add a license for each of these
    https://github.com/oven-sh/bun/blob/main/LICENSE.md

  • The build uses no tarballs since bun is distributed in binary form (building bun requires bun, so I'm guessing is not a good idea to build from source and we should benefit form the binaries).

  • Haven't posted my message to "at" conda-forge/staged-recipes since I'm still reviewing this myself.

Cheers!

@EmmanuelOga
Copy link
Author

EmmanuelOga commented Oct 19, 2024

Also not sure if I need to do something about this:

❯ unzip -l bun-darwin-aarch64
Archive:  bun-darwin-aarch64.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  10-16-2024 22:23   bun-darwin-aarch64/
 60716192  10-16-2024 22:23   bun-darwin-aarch64/bun
---------                     -------
 60716192                     2 files

... that is, the file structure is not flat, so the build script may need to be changed?

Maybe this could work?

build:
  number: 0
  script:
    - mkdir -p $PREFIX/bin
    - mv */bun $PREFIX/bin # Add "*" to match any extracted folder

@EmmanuelOga
Copy link
Author

It is failing to find the meta.yml file, apparently, for some reason.

https://dev.azure.com/conda-forge/84710dde-1620-425b-80d0-4cf5baca359d/_apis/build/builds/1058780/logs/39

2024-10-19T05:22:17.1902420Z + python .ci_support/build_all.py
2024-10-19T05:22:17.1903860Z Building all recipes
2024-10-19T05:22:17.9542300Z Traceback (most recent call last):
2024-10-19T05:22:17.9603630Z   File "/Users/runner/work/1/s/.ci_support/build_all.py", line 340, in <module>
2024-10-19T05:22:17.9684690Z     build_all(os.path.join(root_dir, "recipes"), args.arch)
2024-10-19T05:22:17.9709100Z   File "/Users/runner/work/1/s/.ci_support/build_all.py", line 99, in build_all
2024-10-19T05:22:17.9731030Z     raise ValueError("Neither a meta.yaml or a recipe.yaml recipes was found")
2024-10-19T05:22:17.9761570Z ValueError: Neither a meta.yaml or a recipe.yaml recipes was found

@wolfv wolfv changed the title adding https://bun.sh/ 1.1.31 Adding bun v1.1.31 Oct 19, 2024
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/bun/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/bun/recipe.yaml:

  • license_file entry is missing, but is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants