-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding numpy_quaddtype package #27913
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/numpy_quaddtype/meta.yaml:
|
commenting to confirm my username as maintainer |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/numpy_quaddtype/meta.yaml:
|
Co-authored-by: Filipe <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@ocefpaf I can see the artifacts are generated for all 3 OS, but in the logs I can't see the building and testing process. |
Co-authored-by: Filipe <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11402421614. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@ngoldbaum it seems the following test case of array addition is failing ONLY on Linux env (but passing on our GitHub and local linux testing with same Python version) def test_array_operations():
arr1 = np.array(
[QuadPrecision("1.5"), QuadPrecision("2.5"), QuadPrecision("3.5")])
arr2 = np.array(
[QuadPrecision("0.5"), QuadPrecision("1.0"), QuadPrecision("1.5")])
result = arr1 + arr2
expected = np.array(
[QuadPrecision("2.0"), QuadPrecision("3.5"), QuadPrecision("5.0")])
assert np.all(result == expected) Will be doing some debugging on the conda's Linux environment to see where it is actually failing EDIT-1: Even weird because same operation is working on scalars :) |
This looks good now PS: currently we are loading the source code from temporary (in development) repo, which will be replace in future. So it will possible by performing relevant edits on the feedstock right? |
As long as that is the current home for the project and the release is a stable one, we can merge this. You can change the source URLs later in the feedstock. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).