Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding numpy_quaddtype package #27913

Merged
merged 26 commits into from
Oct 19, 2024
Merged

Conversation

SwayamInSync
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/numpy_quaddtype/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: swayaminsync. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 17, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/numpy_quaddtype/meta.yaml) and found some lint.

Here's what I've got...

For recipes/numpy_quaddtype/meta.yaml:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@SwayamInSync
Copy link
Contributor Author

commenting to confirm my username as maintainer

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/numpy_quaddtype/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/numpy_quaddtype/meta.yaml) and found some lint.

Here's what I've got...

For recipes/numpy_quaddtype/meta.yaml:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/numpy_quaddtype/meta.yaml) and found it was in an excellent condition.

@SwayamInSync
Copy link
Contributor Author

@ocefpaf I can see the artifacts are generated for all 3 OS, but in the logs I can't see the building and testing process.
Is this normal?

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 18, 2024

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11402421614.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/numpy_quaddtype/meta.yaml) and found it was in an excellent condition.

@SwayamInSync
Copy link
Contributor Author

SwayamInSync commented Oct 18, 2024

@ngoldbaum it seems the following test case of array addition is failing ONLY on Linux env (but passing on our GitHub and local linux testing with same Python version)

def test_array_operations():
    arr1 = np.array(
        [QuadPrecision("1.5"), QuadPrecision("2.5"), QuadPrecision("3.5")])
    arr2 = np.array(
        [QuadPrecision("0.5"), QuadPrecision("1.0"), QuadPrecision("1.5")])

    result = arr1 + arr2
    expected = np.array(
        [QuadPrecision("2.0"), QuadPrecision("3.5"), QuadPrecision("5.0")])
    assert np.all(result == expected)

Will be doing some debugging on the conda's Linux environment to see where it is actually failing

EDIT-1: Even weird because same operation is working on scalars :)

@SwayamInSync
Copy link
Contributor Author

This looks good now
cc: @ngoldbaum @ocefpaf

PS: currently we are loading the source code from temporary (in development) repo, which will be replace in future. So it will possible by performing relevant edits on the feedstock right?

@ocefpaf
Copy link
Member

ocefpaf commented Oct 19, 2024

This looks good now cc: @ngoldbaum @ocefpaf

PS: currently we are loading the source code from temporary (in development) repo, which will be replace in future. So it will possible by performing relevant edits on the feedstock right?

As long as that is the current home for the project and the release is a stable one, we can merge this. You can change the source URLs later in the feedstock.

@ocefpaf ocefpaf merged commit a3bcc26 into conda-forge:main Oct 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants