Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependency for ipopt on libscotch #864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 26, 2024

See conda-forge/ipopt-feedstock#112 (comment)

ipopt linked libscotch as a transitive dependency of mumps without declaring it as a dependency, meaning a mumps rebuild against an updated libscotch would break ipopt, which happened with mumps 5.7.3 build 5.

Since mumps pins libscotch all the way down, the only builds for which this is a problem is when a given version of mumps bumps libscotch after ipopt has been built against that mumps.

Since tracking down the scotch at build time for each ipopt build is tedious and the transitive pin from mumps is ~always right for past builds, only apply this patch to the latest version of ipopt (3.14.16).

All builds against mumps 5.6-5.7.2 only have builds against scotch 7.0.4, and only ipopt 3.14.16 has builds against 5.7.3. So while this added dependency is correct, it's only strictly needed to solve a problem for ipopt 3.14.16 build number 5, the first build against mumps 5.7.3.

diff
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
linux-ppc64le
linux-ppc64le::ipopt-3.14.16-h8df03a8_2.conda
linux-ppc64le::ipopt-3.14.16-h4364184_4.conda
linux-ppc64le::ipopt-3.14.16-h8df03a8_3.conda
linux-ppc64le::ipopt-3.14.16-h8d0114a_0.conda
linux-ppc64le::ipopt-3.14.16-h4531137_1.conda
linux-ppc64le::ipopt-3.14.16-h98ba2a6_5.conda
+    "libscotch 7.0.4",
================================================================================
================================================================================
osx-arm64
osx-arm64::ipopt-3.14.16-h4500666_5.conda
osx-arm64::ipopt-3.14.16-h26a4e44_1.conda
osx-arm64::ipopt-3.14.16-h387674d_4.conda
osx-arm64::ipopt-3.14.16-hb0bf214_2.conda
osx-arm64::ipopt-3.14.16-hb0bf214_3.conda
osx-arm64::ipopt-3.14.16-h0662023_0.conda
+    "libscotch 7.0.4",
================================================================================
================================================================================
linux-aarch64
linux-aarch64::ipopt-3.14.16-h7194c4c_0.conda
linux-aarch64::ipopt-3.14.16-hb720d22_1.conda
linux-aarch64::ipopt-3.14.16-h95b2e97_4.conda
linux-aarch64::ipopt-3.14.16-he04425c_2.conda
linux-aarch64::ipopt-3.14.16-ha450752_5.conda
linux-aarch64::ipopt-3.14.16-he04425c_3.conda
+    "libscotch 7.0.4",
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
osx-64::ipopt-3.14.16-h8b46a37_4.conda
osx-64::ipopt-3.14.16-h2f7c220_1.conda
osx-64::ipopt-3.14.16-h37bbb85_0.conda
osx-64::ipopt-3.14.16-h024ff17_3.conda
osx-64::ipopt-3.14.16-h7b94dc9_5.conda
osx-64::ipopt-3.14.16-h024ff17_2.conda
+    "libscotch 7.0.4",
================================================================================
================================================================================
linux-64
linux-64::ipopt-3.14.16-hf967516_0.conda
linux-64::ipopt-3.14.16-h3696c94_4.conda
linux-64::ipopt-3.14.16-h8c03dd0_2.conda
linux-64::ipopt-3.14.16-h8c03dd0_3.conda
linux-64::ipopt-3.14.16-h573144d_1.conda
linux-64::ipopt-3.14.16-h3a0b567_5.conda
+    "libscotch 7.0.4",

@minrk minrk requested a review from a team as a code owner September 26, 2024 12:56
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant