Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch older versions of psiresp to pin dependencies #249

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lilyminium
Copy link

While the newest release has pinned these dependencies properly, the older versions should be patched too.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Relevant: lilyminium/psiresp#93

python show_diff.py
Downloading: https://conda.anaconda.org/conda-forge/noarch/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/noarch/repodata.json.bz2
noarch::psiresp-0.3.1-pyhd8ed1ab_0.tar.bz2
-    "qcfractal",
+    "qcfractal >=0.15",
noarch::psiresp-0.3.1-pyhd8ed1ab_1.tar.bz2
-    "qcfractal",
+    "qcfractal >=0.15",
noarch::psiresp-0.4.0-pyhd8ed1ab_0.tar.bz2
-    "qcfractal",
+    "qcfractal >=0.15",
noarch::psiresp-0.4.1-pyhd8ed1ab_0.tar.bz2
-    "qcfractal",
+    "qcfractal >=0.15",
noarch::psiresp-base-0.3.1-pyhd8ed1ab_0.tar.bz2
-    "tqdm"
+    "tqdm",
+    "pydantic >=1.9"
noarch::psiresp-base-0.3.1-pyhd8ed1ab_2.tar.bz2
-    "pydantic >=1.0",
+    "pydantic >=1.9",
noarch::psiresp-base-0.3.1-pyhd8ed1ab_3.tar.bz2
-    "pydantic >=1.0",
+    "pydantic >=1.9",
noarch::psiresp-base-0.3.1-pyhd8ed1ab_4.tar.bz2
-    "pydantic >=1.0",
+    "pydantic >=1.9",
noarch::psiresp-base-0.4.1-pyhd8ed1ab_1.tar.bz2
-    "pydantic >=1.0",
+    "pydantic >=1.9",
Downloading: https://conda.anaconda.org/conda-forge/linux-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-64/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-armv7l/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-armv7l/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-aarch64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-aarch64/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-ppc64le/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-ppc64le/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-64/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-arm64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-arm64/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-32/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-32/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-64/repodata.json.bz2

@lilyminium lilyminium requested a review from a team as a code owner April 9, 2022 01:37
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some conflicts in the current branch.
As soon as the conflicts are resolve, we should be ready to merge.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@lilyminium
Copy link
Author

Thanks @varlackc! I fixed the merge conflicts.

@hmaarrfk
Copy link
Contributor

Sorry for letting this PR slip.

Is it still relevant 2.5 years later?

You will have to change to the new yaml format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants