Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgal: add cgal/6.0 #25637

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

cgal: add cgal/6.0 #25637

wants to merge 3 commits into from

Conversation

lrineau
Copy link
Contributor

@lrineau lrineau commented Oct 16, 2024

Summary

Changes to recipe: cgal/6.0

Resolves #25050.

Motivation

New upstream release: CGAL version 6.0, https://github.com/CGAL/cgal/releases/tag/v6.0

Details

CGAL 6.0 has a few breaking changes. The major one is that C++17 or later is now required (instead of C++14 for version 5.6).

Also: the PR CGAL/cgal#7512 is merged in CGAL-6.0. That changes the creation of the file lib/cmake/CGAL/conan-official-cgal-variables.cmake, that is now simpler:

include(${CMAKE_CURRENT_LIST_DIR}/CGAL_SetupCGALDependencies.cmake)
CGAL_setup_CGAL_flags(CGAL::CGAL)

# CGAL use may rely on the presence of those two variables
set(CGAL_USE_GMP  TRUE CACHE INTERNAL "CGAL library is configured to use GMP")
set(CGAL_USE_MPFR TRUE CACHE INTERNAL "CGAL library is configured to use MPFR")

@lrineau lrineau mentioned this pull request Oct 16, 2024
60 tasks
@lrineau lrineau changed the title Cgal 6.0 cgal: add cgal/6.0 Oct 16, 2024
@lrineau lrineau mentioned this pull request Oct 16, 2024
3 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@lrineau lrineau marked this pull request as ready for review October 16, 2024 22:05
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 3 (d798cb03831359e879a8ca48dd1591b1321c3a4e):

  • cgal/5.3.2:
    Built 5 packages out of 11 (All logs)

  • cgal/5.5.2:
    Built 5 packages out of 11 (All logs)

  • cgal/5.5:
    Built 5 packages out of 11 (All logs)

  • cgal/5.5.1:
    Built 5 packages out of 11 (All logs)

  • cgal/5.5.3:
    Built 5 packages out of 11 (All logs)

  • cgal/6.0:
    Built 5 packages out of 11 (All logs)

  • cgal/5.6.1:
    Built 5 packages out of 11 (All logs)

  • cgal/5.6:
    Built 5 packages out of 11 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (d798cb03831359e879a8ca48dd1591b1321c3a4e):

  • cgal/5.3.2:
    Built 4 packages out of 5 (All logs)

  • cgal/5.5.1:
    Built 4 packages out of 5 (All logs)

  • cgal/5.5.2:
    Built 4 packages out of 5 (All logs)

  • cgal/5.6:
    Built 4 packages out of 5 (All logs)

  • cgal/5.5.3:
    Built 4 packages out of 5 (All logs)

  • cgal/5.6.1:
    Built 4 packages out of 5 (All logs)

  • cgal/5.5:
    Built 4 packages out of 5 (All logs)

  • cgal/6.0:
    Built 4 packages out of 5 (All logs)

@AbrilRBS AbrilRBS self-assigned this Oct 17, 2024
@lrineau
Copy link
Contributor Author

lrineau commented Oct 17, 2024

Hi @AbrilRBS. Let me know if there is anything I should do about this PR. I am unsure about the PR #25050, that adds cgal/6.0-beta1. This one is about cgal/6.0, the official release.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! We appreciate you taking the time to create the PR for the new release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants