Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tech stack tags to ProjectCard component #152

Merged
merged 26 commits into from
Jul 10, 2024

Conversation

lemonteaau
Copy link
Collaborator

@lemonteaau lemonteaau commented Jul 8, 2024

Description

Add tech stack tags to ProjectCard component & FutureProjectCard component for displaying future projects

Changes Made

  • Add Tag & FutureProjectCard components
  • Add techStack in projects.ts
  • Add future-project.ts
  • Add future project placeholder image
  • Add Tag and FutureProjectCard components in ProjectCard.tsx

Related Issues

Add feature according to #151

Additional Notes

src/components/Tag.tsx Show resolved Hide resolved
src/constants/colours.ts Outdated Show resolved Hide resolved
src/constants/colours.ts Outdated Show resolved Hide resolved
src/data/future-projects.ts Show resolved Hide resolved
src/data/future-projects.ts Show resolved Hide resolved
src/components/Tag.tsx Outdated Show resolved Hide resolved
src/app/open-source/FutureProjectCard.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@rayokamoto rayokamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes + added to the discussion on colour contrast.

src/components/Tag.tsx Show resolved Hide resolved
src/constants/colours.ts Outdated Show resolved Hide resolved
src/constants/colours.ts Outdated Show resolved Hide resolved
src/data/future-projects.ts Outdated Show resolved Hide resolved
src/constants/colours.ts Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@lemonteaau lemonteaau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done

src/constants/colours.ts Outdated Show resolved Hide resolved
src/constants/colours.ts Outdated Show resolved Hide resolved
Co-authored-by: Ray Okamoto <[email protected]>
Copy link
Member

@jsun969 jsun969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just a few suggestions

src/constants/colours.ts Outdated Show resolved Hide resolved
src/data/projects.ts Outdated Show resolved Hide resolved
src/app/open-source/FutureProjectCard.tsx Outdated Show resolved Hide resolved
Copy link
Member

@jsun969 jsun969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@phoenixpereira phoenixpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayokamoto rayokamoto merged commit 0dbed4c into compsci-adl:main Jul 10, 2024
3 checks passed
@phoenixpereira phoenixpereira linked an issue Jul 10, 2024 that may be closed by this pull request
@lemonteaau lemonteaau deleted the issue#151 branch July 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add future projects and tech stacks
4 participants