Improved support for GitLab #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! |
stof
reviewed
Jan 8, 2024
| @@ -274,6 +274,30 @@ public function getVendor(): string | |||
| return $this->vendor; | |||
| } | |||
|
|
|||
| /** | |||
| * @return array<string> Vendor and package name | |||
There was a problem hiding this comment.
the return type is wrong. It is array<string>|false
There was a problem hiding this comment.
and the naming looks weird as the name makes us think it should return a boolean.
Seldaek
added a commit
that referenced
this pull request
Jan 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refers to #1406 and depends on this other PR for Composer (merged but actually to be yet included in a versioned release).
Provides some extra support for packages hosted on gitlab.com, in particular for stars and forks counters.
Considerations:
isGitHub()andisGitLab()functions inApp\Entity\Packageto wrap provider's guessing based on repository URL