Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On password reset require 2FA code before storing new password #1403

Merged
merged 4 commits into from
Jan 8, 2024
Merged

On password reset require 2FA code before storing new password #1403

merged 4 commits into from
Jan 8, 2024

Conversation

glaubinix
Copy link
Contributor

@glaubinix glaubinix commented Nov 17, 2023 •
edited
Loading

Resolves #1293

  • Extracted 2FA code validation into form constraint + validator
  • Added 2FA code stub to make 2FA testing easier
  • Tests for 2FA enable + password reset
  • Reset password now requests a 2FA code before password is reset

stof
stof reviewed Nov 17, 2023
View reviewed changes
src/Controller/UserController.php Outdated Show resolved Hide resolved
src/Form/Type/EnableTwoFactorAuthType.php Outdated Show resolved Hide resolved
src/EventListener/ResolvedTwoFactorCodeCredentialsListener.php Outdated Show resolved Hide resolved
src/Form/ResetPasswordFormType.php Outdated Show resolved Hide resolved
@glaubinix
Apply review feedback:
7c266b1 
- better form options
- define listener event on method instead of class
- avoid initializing new totp secret on every request
@glaubinix
Copy link
Contributor Author

Thanks!

@Seldaek Seldaek merged commit a564062 into composer:main Jan 8, 2024
3 checks passed
@Seldaek
Copy link
Member

Seldaek commented Jan 8, 2024

Looks good thanks!

@Seldaek Seldaek added the Feature label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2FA requirement when using "password forgotten"
3 participants
@glaubinix @Seldaek @stof