use version as argument for getInstallCommand

composer · Mar 8, 2024 · 020a71d · 020a71d
1 parent 3a389da
commit 020a71d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/Entity/Package.php b/src/Entity/Package.php
@@ -687,16 +687,14 @@ public function getType(): string|null
  return $this->type;
  }
 
- public function getInstallCommand(): string
+ public function getInstallCommand(Version $version = null): string
  {
  $command = 'create-project';
 
  if ('project' !== $this->getType()) {
  $command = 'require';
 
- /** @var Version $version */
- $version = $this->getVersions()->first();
- if ($version && $version->hasDevTag()) {
+ if (null !== $version && $version->hasDevTag()) {
  $command .= ' --dev';
  }
  }

diff --git a/templates/package/view_package.html.twig b/templates/package/view_package.html.twig
@@ -46,7 +46,7 @@
 
  <div class="row">
  <div class="col-md-8">
- <p class="requireme"><i class="glyphicon glyphicon-save"></i> <input type="text" readonly="readonly" value="{{ package.installCommand }}" /></p>
+ <p class="requireme"><i class="glyphicon glyphicon-save"></i> <input type="text" readonly="readonly" value="{{ package.installCommand(expandedVersion) }}" /></p>
 
  {% if not package.isAutoUpdated() and is_granted('update', package) %}
  {% if "github.com" in package.repository %}

diff --git a/tests/Entity/PackageTest.php b/tests/Entity/PackageTest.php
@@ -41,9 +41,8 @@ public function testInstallCommand(string $type, string $tag, string $expected):
  $package = new Package();
  $package->setName('vendor/name');
  $package->setType($type);
- $package->addVersion($version);
 
- self::assertSame($expected, $package->getInstallCommand());
+ self::assertSame($expected, $package->getInstallCommand($version));
  }
 
  public static function providePackageScenarios(): array