LogDensityProblemsAD parent method (#198)

* Add + test parent method * Formatting * Bump patch version
compintell · Jul 23, 2024 · d268fd7 · d268fd7 · willtebbutt · Jul 23, 2024
1 parent 135bf80
commit d268fd7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Tapir"
 uuid = "07d77754-e150-4737-8c94-cd238a1fb45b"
 authors = ["Will Tebbutt, Hong Ge, and contributors"]
-version = "0.2.24"
+version = "0.2.25"
 
 [deps]
 ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"

diff --git a/ext/TapirLogDensityProblemsADExt.jl b/ext/TapirLogDensityProblemsADExt.jl
@@ -67,4 +67,6 @@ function ADgradient(x::ADTypes.AutoTapir, ℓ)
     return ADgradient(Val(:Tapir), ℓ; safety_on=x.safe_mode)
 end
 
+Base.parent(x::TapirGradientLogDensity) = Tapir.primal(x.ℓ)
+
 end
diff --git a/test/integration_testing/logdensityproblemsad_interop.jl b/test/integration_testing/logdensityproblemsad_interop.jl
@@ -21,4 +21,5 @@ test_gradient(x) = -2 .* x
     end
 
     @test ADgradient(ADTypes.AutoTapir(safe_mode=false), l) isa typeof(∇l)
+    @test parent(∇l) === l
 end
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -46,7 +46,7 @@ include("front_matter.jl")
         include("chain_rules_macro.jl")
     elseif test_group == "integration_testing/misc"
         include(joinpath("integration_testing", "logdensityproblemsad_interop.jl"))
-        include(joinpath("integration_testing/", "misc.jl"))
+        include(joinpath("integration_testing", "misc.jl"))
         include(joinpath("integration_testing", "battery_tests.jl"))
     elseif test_group == "integration_testing/diff_tests"
         include(joinpath("integration_testing", "diff_tests.jl"))