Skip to content

Commit

Permalink
Prevent Stack Overflow (#309)
Browse files Browse the repository at this point in the history
* Do not splat vcat

* Bump patch version
  • Loading branch information
willtebbutt authored Oct 22, 2024
1 parent 4b28eb9 commit 77d1cec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Mooncake"
uuid = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6"
authors = ["Will Tebbutt, Hong Ge, and contributors"]
version = "0.4.21"
version = "0.4.22"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down
2 changes: 1 addition & 1 deletion src/interpreter/s2s_reverse_mode_ad.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,7 @@ function pullback_ir(
rvs_block = BBlock(blk_id, vcat(comms_insts, rvs_ad_stmts, additional_stmts))
return vcat(rvs_block, new_blocks)
end
main_blocks = vcat(main_blocks...)
main_blocks = reduce(vcat, main_blocks)

# Create an exit block. Dereferences reverse-data for arguments, increments a zero rdata
# against it to ensure that it is of the correct type, and returns it.
Expand Down

2 comments on commit 77d1cec

@willtebbutt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/117830

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.22 -m "<description of version>" 77d1cecf76beca5ac769ffe3aa586f5c95ca9800
git push origin v0.4.22

Please sign in to comment.