fixed issue #5829 #5869
Open
fixed issue #5829 #5869
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5829
What changes did you make and why?
Since currently when you pause all the upload and delete them, the app is still at paused state, making future uploads unable to start automatically(you need to click the restart button after creating new uploads)
i modified deleteUpload() in PendingUploadsFragment.kt.
To give future uploads a fresh start after pausing and deleting all the pending upload, I added some code to check if the deleted upload is the last one, if yes, set the app off paused.
Tests performed (required)
Tested ProdDebug build variant on Pixel 3a emulator with API level 34.
I manually tested the changes by pausing all uploads, deleting them, and confirming that new uploads start automatically without needing to click the restart button. Since this change only affects a small part of the code, I believe manual testing is sufficient to verify the functionality.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.